From 46562be227b16d6ef4dfd07ff4496f8d87d296a8 Mon Sep 17 00:00:00 2001
From: Andreas Nedbal <andreas.nedbal@in2code.de>
Date: Sun, 6 Mar 2022 11:17:43 +0100
Subject: [PATCH] Refactor: Switch Settings index page to setup sugar (#8374)

* refactor(client): Make Settings index page use <script setup>

* chore(client): address review comments
---
 packages/client/src/pages/settings/index.vue | 440 +++++++++----------
 1 file changed, 209 insertions(+), 231 deletions(-)

diff --git a/packages/client/src/pages/settings/index.vue b/packages/client/src/pages/settings/index.vue
index ac8414ddb..42e40c5ac 100644
--- a/packages/client/src/pages/settings/index.vue
+++ b/packages/client/src/pages/settings/index.vue
@@ -22,8 +22,8 @@
 </MkSpacer>
 </template>
 
-<script lang="ts">
-import { computed, defineAsyncComponent, defineComponent, nextTick, onMounted, reactive, ref, watch } from 'vue';
+<script setup lang="ts">
+import { computed, defineAsyncComponent, nextTick, onMounted, ref, watch } from 'vue';
 import { i18n } from '@/i18n';
 import MkInfo from '@/components/ui/info.vue';
 import MkSuperMenu from '@/components/ui/super-menu.vue';
@@ -34,241 +34,219 @@ import * as symbols from '@/symbols';
 import { instance } from '@/instance';
 import { $i } from '@/account';
 
-export default defineComponent({
-	components: {
-		MkInfo,
-		MkSuperMenu,
-	},
+const props = defineProps<{
+  initialPage?: string
+}>();
 
-	props: {
-		initialPage: {
-			type: String,
-			required: false
+const indexInfo = {
+	title: i18n.ts.settings,
+	icon: 'fas fa-cog',
+	bg: 'var(--bg)',
+	hideHeader: true,
+};
+const INFO = ref(indexInfo);
+const page = ref(props.initialPage);
+const narrow = ref(false);
+const view = ref(null);
+const el = ref<HTMLElement | null>(null);
+const childInfo = ref(null);
+const menuDef = computed(() => [{
+	title: i18n.ts.basicSettings,
+	items: [{
+		icon: 'fas fa-user',
+		text: i18n.ts.profile,
+		to: '/settings/profile',
+		active: page.value === 'profile',
+	}, {
+		icon: 'fas fa-lock-open',
+		text: i18n.ts.privacy,
+		to: '/settings/privacy',
+		active: page.value === 'privacy',
+	}, {
+		icon: 'fas fa-laugh',
+		text: i18n.ts.reaction,
+		to: '/settings/reaction',
+		active: page.value === 'reaction',
+	}, {
+		icon: 'fas fa-cloud',
+		text: i18n.ts.drive,
+		to: '/settings/drive',
+		active: page.value === 'drive',
+	}, {
+		icon: 'fas fa-bell',
+		text: i18n.ts.notifications,
+		to: '/settings/notifications',
+		active: page.value === 'notifications',
+	}, {
+		icon: 'fas fa-envelope',
+		text: i18n.ts.email,
+		to: '/settings/email',
+		active: page.value === 'email',
+	}, {
+		icon: 'fas fa-share-alt',
+		text: i18n.ts.integration,
+		to: '/settings/integration',
+		active: page.value === 'integration',
+	}, {
+		icon: 'fas fa-lock',
+		text: i18n.ts.security,
+		to: '/settings/security',
+		active: page.value === 'security',
+	}],
+}, {
+	title: i18n.ts.clientSettings,
+	items: [{
+		icon: 'fas fa-cogs',
+		text: i18n.ts.general,
+		to: '/settings/general',
+		active: page.value === 'general',
+	}, {
+		icon: 'fas fa-palette',
+		text: i18n.ts.theme,
+		to: '/settings/theme',
+		active: page.value === 'theme',
+	}, {
+		icon: 'fas fa-list-ul',
+		text: i18n.ts.menu,
+		to: '/settings/menu',
+		active: page.value === 'menu',
+	}, {
+		icon: 'fas fa-music',
+		text: i18n.ts.sounds,
+		to: '/settings/sounds',
+		active: page.value === 'sounds',
+	}, {
+		icon: 'fas fa-plug',
+		text: i18n.ts.plugins,
+		to: '/settings/plugin',
+		active: page.value === 'plugin',
+	}],
+}, {
+	title: i18n.ts.otherSettings,
+	items: [{
+		icon: 'fas fa-boxes',
+		text: i18n.ts.importAndExport,
+		to: '/settings/import-export',
+		active: page.value === 'import-export',
+	}, {
+		icon: 'fas fa-volume-mute',
+		text: i18n.ts.instanceMute,
+		to: '/settings/instance-mute',
+		active: page.value === 'instance-mute',
+	}, {
+		icon: 'fas fa-ban',
+		text: i18n.ts.muteAndBlock,
+		to: '/settings/mute-block',
+		active: page.value === 'mute-block',
+	}, {
+		icon: 'fas fa-comment-slash',
+		text: i18n.ts.wordMute,
+		to: '/settings/word-mute',
+		active: page.value === 'word-mute',
+	}, {
+		icon: 'fas fa-key',
+		text: 'API',
+		to: '/settings/api',
+		active: page.value === 'api',
+	}, {
+		icon: 'fas fa-ellipsis-h',
+		text: i18n.ts.other,
+		to: '/settings/other',
+		active: page.value === 'other',
+	}],
+}, {
+	items: [{
+		type: 'button',
+		icon: 'fas fa-trash',
+		text: i18n.ts.clearCache,
+		action: () => {
+			localStorage.removeItem('locale');
+			localStorage.removeItem('theme');
+			unisonReload();
+		},
+	}, {
+		type: 'button',
+		icon: 'fas fa-sign-in-alt fa-flip-horizontal',
+		text: i18n.ts.logout,
+		action: () => {
+			signout();
+		},
+		danger: true,
+	},],
+}]);
+
+const pageProps = ref({});
+const component = computed(() => {
+	if (page.value == null) return null;
+	switch (page.value) {
+		case 'accounts': return defineAsyncComponent(() => import('./accounts.vue'));
+		case 'profile': return defineAsyncComponent(() => import('./profile.vue'));
+		case 'privacy': return defineAsyncComponent(() => import('./privacy.vue'));
+		case 'reaction': return defineAsyncComponent(() => import('./reaction.vue'));
+		case 'drive': return defineAsyncComponent(() => import('./drive.vue'));
+		case 'notifications': return defineAsyncComponent(() => import('./notifications.vue'));
+		case 'mute-block': return defineAsyncComponent(() => import('./mute-block.vue'));
+		case 'word-mute': return defineAsyncComponent(() => import('./word-mute.vue'));
+		case 'instance-mute': return defineAsyncComponent(() => import('./instance-mute.vue'));
+		case 'integration': return defineAsyncComponent(() => import('./integration.vue'));
+		case 'security': return defineAsyncComponent(() => import('./security.vue'));
+		case '2fa': return defineAsyncComponent(() => import('./2fa.vue'));
+		case 'api': return defineAsyncComponent(() => import('./api.vue'));
+		case 'apps': return defineAsyncComponent(() => import('./apps.vue'));
+		case 'other': return defineAsyncComponent(() => import('./other.vue'));
+		case 'general': return defineAsyncComponent(() => import('./general.vue'));
+		case 'email': return defineAsyncComponent(() => import('./email.vue'));
+		case 'theme': return defineAsyncComponent(() => import('./theme.vue'));
+		case 'theme/install': return defineAsyncComponent(() => import('./theme.install.vue'));
+		case 'theme/manage': return defineAsyncComponent(() => import('./theme.manage.vue'));
+		case 'menu': return defineAsyncComponent(() => import('./menu.vue'));
+		case 'sounds': return defineAsyncComponent(() => import('./sounds.vue'));
+		case 'custom-css': return defineAsyncComponent(() => import('./custom-css.vue'));
+		case 'deck': return defineAsyncComponent(() => import('./deck.vue'));
+		case 'plugin': return defineAsyncComponent(() => import('./plugin.vue'));
+		case 'plugin/install': return defineAsyncComponent(() => import('./plugin.install.vue'));
+		case 'import-export': return defineAsyncComponent(() => import('./import-export.vue'));
+		case 'account-info': return defineAsyncComponent(() => import('./account-info.vue'));
+		case 'delete-account': return defineAsyncComponent(() => import('./delete-account.vue'));
+	}
+	return null;
+});
+
+watch(component, () => {
+	pageProps.value = {};
+
+	nextTick(() => {
+		scroll(el.value, { top: 0 });
+	});
+}, { immediate: true });
+
+watch(() => props.initialPage, () => {
+	if (props.initialPage == null && !narrow.value) {
+		page.value = 'profile';
+	} else {
+		page.value = props.initialPage;
+		if (props.initialPage == null) {
+			INFO.value = indexInfo;
 		}
-	},
+	}
+});
 
-	setup(props, context) {
-		const indexInfo = {
-			title: i18n.ts.settings,
-			icon: 'fas fa-cog',
-			bg: 'var(--bg)',
-			hideHeader: true,
-		};
-		const INFO = ref(indexInfo);
-		const page = ref(props.initialPage);
-		const narrow = ref(false);
-		const view = ref(null);
-		const el = ref(null);
-		const childInfo = ref(null);
-		const menuDef = computed(() => [{
-			title: i18n.ts.basicSettings,
-			items: [{
-				icon: 'fas fa-user',
-				text: i18n.ts.profile,
-				to: '/settings/profile',
-				active: page.value === 'profile',
-			}, {
-				icon: 'fas fa-lock-open',
-				text: i18n.ts.privacy,
-				to: '/settings/privacy',
-				active: page.value === 'privacy',
-			}, {
-				icon: 'fas fa-laugh',
-				text: i18n.ts.reaction,
-				to: '/settings/reaction',
-				active: page.value === 'reaction',
-			}, {
-				icon: 'fas fa-cloud',
-				text: i18n.ts.drive,
-				to: '/settings/drive',
-				active: page.value === 'drive',
-			}, {
-				icon: 'fas fa-bell',
-				text: i18n.ts.notifications,
-				to: '/settings/notifications',
-				active: page.value === 'notifications',
-			}, {
-				icon: 'fas fa-envelope',
-				text: i18n.ts.email,
-				to: '/settings/email',
-				active: page.value === 'email',
-			}, {
-				icon: 'fas fa-share-alt',
-				text: i18n.ts.integration,
-				to: '/settings/integration',
-				active: page.value === 'integration',
-			}, {
-				icon: 'fas fa-lock',
-				text: i18n.ts.security,
-				to: '/settings/security',
-				active: page.value === 'security',
-			}],
-		}, {
-			title: i18n.ts.clientSettings,
-			items: [{
-				icon: 'fas fa-cogs',
-				text: i18n.ts.general,
-				to: '/settings/general',
-				active: page.value === 'general',
-			}, {
-				icon: 'fas fa-palette',
-				text: i18n.ts.theme,
-				to: '/settings/theme',
-				active: page.value === 'theme',
-			}, {
-				icon: 'fas fa-list-ul',
-				text: i18n.ts.menu,
-				to: '/settings/menu',
-				active: page.value === 'menu',
-			}, {
-				icon: 'fas fa-music',
-				text: i18n.ts.sounds,
-				to: '/settings/sounds',
-				active: page.value === 'sounds',
-			}, {
-				icon: 'fas fa-plug',
-				text: i18n.ts.plugins,
-				to: '/settings/plugin',
-				active: page.value === 'plugin',
-			}],
-		}, {
-			title: i18n.ts.otherSettings,
-			items: [{
-				icon: 'fas fa-boxes',
-				text: i18n.ts.importAndExport,
-				to: '/settings/import-export',
-				active: page.value === 'import-export',
-			}, {
-				icon: 'fas fa-volume-mute',
-				text: i18n.ts.instanceMute,
-				to: '/settings/instance-mute',
-				active: page.value === 'instance-mute',
-			}, {
-				icon: 'fas fa-ban',
-				text: i18n.ts.muteAndBlock,
-				to: '/settings/mute-block',
-				active: page.value === 'mute-block',
-			}, {
-				icon: 'fas fa-comment-slash',
-				text: i18n.ts.wordMute,
-				to: '/settings/word-mute',
-				active: page.value === 'word-mute',
-			}, {
-				icon: 'fas fa-key',
-				text: 'API',
-				to: '/settings/api',
-				active: page.value === 'api',
-			}, {
-				icon: 'fas fa-ellipsis-h',
-				text: i18n.ts.other,
-				to: '/settings/other',
-				active: page.value === 'other',
-			}],
-		}, {
-			items: [{
-				type: 'button',
-				icon: 'fas fa-trash',
-				text: i18n.ts.clearCache,
-				action: () => {
-					localStorage.removeItem('locale');
-					localStorage.removeItem('theme');
-					unisonReload();
-				},
-			}, {
-				type: 'button',
-				icon: 'fas fa-sign-in-alt fa-flip-horizontal',
-				text: i18n.ts.logout,
-				action: () => {
-					signout();
-				},
-				danger: true,
-			},],
-		}]);
+onMounted(() => {
+	narrow.value = el.value.offsetWidth < 800;
+	if (!narrow.value) {
+		page.value = 'profile';
+	}
+});
 
-		const pageProps = ref({});
-		const component = computed(() => {
-			if (page.value == null) return null;
-			switch (page.value) {
-				case 'accounts': return defineAsyncComponent(() => import('./accounts.vue'));
-				case 'profile': return defineAsyncComponent(() => import('./profile.vue'));
-				case 'privacy': return defineAsyncComponent(() => import('./privacy.vue'));
-				case 'reaction': return defineAsyncComponent(() => import('./reaction.vue'));
-				case 'drive': return defineAsyncComponent(() => import('./drive.vue'));
-				case 'notifications': return defineAsyncComponent(() => import('./notifications.vue'));
-				case 'mute-block': return defineAsyncComponent(() => import('./mute-block.vue'));
-				case 'word-mute': return defineAsyncComponent(() => import('./word-mute.vue'));
-				case 'instance-mute': return defineAsyncComponent(() => import('./instance-mute.vue'));
-				case 'integration': return defineAsyncComponent(() => import('./integration.vue'));
-				case 'security': return defineAsyncComponent(() => import('./security.vue'));
-				case '2fa': return defineAsyncComponent(() => import('./2fa.vue'));
-				case 'api': return defineAsyncComponent(() => import('./api.vue'));
-				case 'apps': return defineAsyncComponent(() => import('./apps.vue'));
-				case 'other': return defineAsyncComponent(() => import('./other.vue'));
-				case 'general': return defineAsyncComponent(() => import('./general.vue'));
-				case 'email': return defineAsyncComponent(() => import('./email.vue'));
-				case 'theme': return defineAsyncComponent(() => import('./theme.vue'));
-				case 'theme/install': return defineAsyncComponent(() => import('./theme.install.vue'));
-				case 'theme/manage': return defineAsyncComponent(() => import('./theme.manage.vue'));
-				case 'menu': return defineAsyncComponent(() => import('./menu.vue'));
-				case 'sounds': return defineAsyncComponent(() => import('./sounds.vue'));
-				case 'custom-css': return defineAsyncComponent(() => import('./custom-css.vue'));
-				case 'deck': return defineAsyncComponent(() => import('./deck.vue'));
-				case 'plugin': return defineAsyncComponent(() => import('./plugin.vue'));
-				case 'plugin/install': return defineAsyncComponent(() => import('./plugin.install.vue'));
-				case 'import-export': return defineAsyncComponent(() => import('./import-export.vue'));
-				case 'account-info': return defineAsyncComponent(() => import('./account-info.vue'));
-				case 'delete-account': return defineAsyncComponent(() => import('./delete-account.vue'));
-			}
-			return null;
-		});
+const emailNotConfigured = computed(() => instance.enableEmail && ($i.email == null || !$i.emailVerified));
 
-		watch(component, () => {
-			pageProps.value = {};
+const pageChanged = (page) => {
+	if (page == null) return;
+	childInfo.value = page[symbols.PAGE_INFO];
+};
 
-			nextTick(() => {
-				scroll(el.value, { top: 0 });
-			});
-		}, { immediate: true });
-
-		watch(() => props.initialPage, () => {
-			if (props.initialPage == null && !narrow.value) {
-				page.value = 'profile';
-			} else {
-				page.value = props.initialPage;
-				if (props.initialPage == null) {
-					INFO.value = indexInfo;
-				}
-			}
-		});
-
-		onMounted(() => {
-			narrow.value = el.value.offsetWidth < 800;
-			if (!narrow.value) {
-				page.value = 'profile';
-			}
-		});
-
-		const emailNotConfigured = computed(() => instance.enableEmail && ($i.email == null || !$i.emailVerified));
-
-		const pageChanged = (page) => {
-			if (page == null) return;
-			childInfo.value = page[symbols.PAGE_INFO];
-		};
-
-		return {
-			[symbols.PAGE_INFO]: INFO,
-			page,
-			menuDef,
-			narrow,
-			view,
-			el,
-			pageProps,
-			component,
-			emailNotConfigured,
-			pageChanged,
-			childInfo,
-		};
-	},
+defineExpose({
+	[symbols.PAGE_INFO]: INFO,
 });
 </script>